chore: add OCR scaffolding to PDF Viewer #38127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
support-pdf-ocr
branch
from
0398b42
to
20d832e
Compare
deepak1556
reviewed
Apr 28, 2023
deepak1556
approved these changes
May 2, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/25-x-y
|
@codebytere has manually backported this PR to "25-x-y", please check out #38148 |
trop
bot
added
in-flight/25-x-y
merged/25-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes the following error seen when opening any PDF file:
[60553:0426/210509.819782:INFO:CONSOLE(419)] "Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'isPdfOcrAlwaysActive')", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_viewer_wrapper.js (419)This is a PDF Accessibility feature under active development here that eventually i'd like to support, which allows screen readers to read PDFs from scanned images that they wouldn't normally be able to. For now, this adds minimal scaffolding for the feature and leaves it disabled.
Checklist
npm testpassesRelease Notes
Notes: Fixes a console error seen when loading PDFs.