Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle AXManualAccessibility attribute cross-protocol #38142

Merged
merged 2 commits into from May 9, 2023
Merged

fix: handle AXManualAccessibility attribute cross-protocol #38142

merged 2 commits into from May 9, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Follow-up to #38102. Ensure that Electron's custom AXManualAccessibility attribute works as expected in all relevant protocol methods.

Checklist

Release Notes

Notes: Ensure that Electron's custom AXManualAccessibility attribute works as expected in all relevant protocol methods.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 2, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 2, 2023
@codebytere codebytere requested a review from deepak1556 May 4, 2023 09:30
@codebytere @deepak1556
Update shell/browser/mac/electron_application.mm
9cd14ec 
Co-authored-by: Robo <hop2deep@gmail.com>
@codebytere codebytere requested a review from deepak1556 May 8, 2023 07:58
@codebytere
Copy link
Member Author

Unrelated known flake - merging.

@codebytere codebytere merged commit f432245 into main May 9, 2023
16 of 17 checks passed
@codebytere codebytere deleted the axmanuala11y branch May 9, 2023 09:13
@release-clerk
Copy link

release-clerk bot commented May 9, 2023

Release Notes Persisted

Ensure that Electron's custom AXManualAccessibility attribute works as expected in all relevant protocol methods.

@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels May 9, 2023
@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels May 9, 2023
@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels May 9, 2023
@codebytere codebytere mentioned this pull request May 9, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2023

@codebytere has manually backported this PR to "25-x-y", please check out #38223

codebytere added a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38142)
9fec081 
* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: Robo <hop2deep@gmail.com>
codebytere added a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38142)
cf74870 
* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: Robo <hop2deep@gmail.com>
@codebytere codebytere mentioned this pull request May 9, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2023

@codebytere has manually backported this PR to "24-x-y", please check out #38224

codebytere added a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38142)
feeaadd 
* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: Robo <hop2deep@gmail.com>
@codebytere codebytere mentioned this pull request May 9, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 9, 2023

@codebytere has manually backported this PR to "23-x-y", please check out #38225

jkleinsc pushed a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38223)
5008e3e 
fix: handle `AXManualAccessibility` attribute cross-protocol (#38142)

* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm



---------

Co-authored-by: Robo <hop2deep@gmail.com>
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/24-x-y labels May 9, 2023
jkleinsc pushed a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38224)
ea68961 
fix: handle `AXManualAccessibility` attribute cross-protocol (#38142)

* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm



---------

Co-authored-by: Robo <hop2deep@gmail.com>
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/23-x-y labels May 9, 2023
jkleinsc pushed a commit that referenced this pull request May 9, 2023
@codebytere @deepak1556
fix: handle AXManualAccessibility attribute cross-protocol (#38225)
0eb53be 
fix: handle `AXManualAccessibility` attribute cross-protocol (#38142)

* fix: handle AXManualAccessibility attribute cross-protocol

* Update shell/browser/mac/electron_application.mm



---------

Co-authored-by: Robo <hop2deep@gmail.com>
@trop trop bot added the merged/23-x-y PR was merged to the "23-x-y" branch. label May 9, 2023
@commit-lint commit-lint bot mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @deepak1556