Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix TrustedTypes policy in chrome://accessibility #38179

Merged
merged 1 commit into from May 8, 2023
Merged

chore: fix TrustedTypes policy in chrome://accessibility #38179

merged 1 commit into from May 8, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Refs CL:4219030

Fixes the following error seen when loading chrome://accessibility, which prevented the Top Level Windows section from populating:

[59750:0504/101326.049599:ERROR:CONSOLE(27)] "Refused to create a TrustedTypePolicy named 'sanitize-inner-html' because it violates the following Content Security Policy directive: "trusted-types ".", source: chrome://resources/js/parse_html_subset.js (27)
[59750:0504/101326.049984:ERROR:CONSOLE(27)] "Uncaught TypeError: Failed to execute 'createPolicy' on 'TrustedTypePolicyFactory': Policy "sanitize-inner-html" disallowed.", source: chrome://resources/js/parse_html_subset.js (27)

Checklist

Release Notes

Notes: Fixed an error seen in the Top Level Windows section of chrome://accessibility.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. labels May 4, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2023
@codebytere codebytere merged commit a6c9aef into main May 8, 2023
15 checks passed
@codebytere codebytere deleted the fix-ally-trusted-types-bug branch May 8, 2023 08:39
@release-clerk
Copy link

release-clerk bot commented May 8, 2023

Release Notes Persisted

Fixed an error seen in the Top Level Windows section of chrome://accessibility.

@trop trop bot mentioned this pull request May 8, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 8, 2023

I have automatically backported this PR to "25-x-y", please check out #38211

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/25-x-y labels May 8, 2023
@commit-lint commit-lint bot mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @deepak1556