-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick d42c3e5fb7c3 from chromium #38199
chore: cherry-pick d42c3e5fb7c3 from chromium #38199
Conversation
d72fbd5
to
037c388
Compare
Very cool from you @vially, thank you for working on this |
Release Notes Persisted
|
Will this fix make it to the other versions of electron? It's still crashing on the VSCode insider build which is on electron 25 and still crashes Obsidian which is on electron 24. |
@chrisr87 the fix was backported to Electron 22, which means all branches >= 22 already contain this fix. If the crash is still present with E24 then it must be a different source, can you provide crash dumps or steps to repro and open an issue ? Thanks! |
Apologies was mistaken, the new VSCode Insiders does work properly now and it seems that Obsidian is on electron 22.3.3. |
Thanks for confirming! |
Description of Change
Manual backporting of 4099423 for fixing a drag-and-drop crash on wlroots based compositors (e.g.: sway, Hyprland, wayfire, etc).
This is currently causing crashes for vscode users on Wayland (microsoft/vscode#179836 and possibly also microsoft/vscode#181533).
Checklist
npm test
passesRelease Notes
Notes: Fixed drag-and-drop crash on Wayland.