Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick d42c3e5fb7c3 from chromium #38199

Merged

Conversation

vially
Copy link
Contributor

@vially vially commented May 5, 2023

Description of Change

Manual backporting of 4099423 for fixing a drag-and-drop crash on wlroots based compositors (e.g.: sway, Hyprland, wayfire, etc).

This is currently causing crashes for vscode users on Wayland (microsoft/vscode#179836 and possibly also microsoft/vscode#181533).

Checklist

Release Notes

Notes: Fixed drag-and-drop crash on Wayland.

@vially vially requested a review from a team as a code owner May 5, 2023 23:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 5, 2023
@vially vially force-pushed the cherry-pick/chromium/d42c3e5fb7c3 branch from d72fbd5 to 037c388 Compare May 6, 2023 19:49
@realtimetodie
Copy link

Very cool from you @vially, thank you for working on this

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking labels May 8, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 8, 2023
@codebytere codebytere merged commit 5af5b42 into electron:22-x-y May 9, 2023
13 of 14 checks passed
@release-clerk
Copy link

release-clerk bot commented May 9, 2023

Release Notes Persisted

Fixed drag-and-drop crash on Wayland.

@chrisr87
Copy link

chrisr87 commented May 25, 2023

Will this fix make it to the other versions of electron? It's still crashing on the VSCode insider build which is on electron 25 and still crashes Obsidian which is on electron 24.

@deepak1556
Copy link
Member

@chrisr87 the fix was backported to Electron 22, which means all branches >= 22 already contain this fix. If the crash is still present with E24 then it must be a different source, can you provide crash dumps or steps to repro and open an issue ? Thanks!

@chrisr87
Copy link

chrisr87 commented May 26, 2023

@chrisr87 the fix was backported to Electron 22, which means all branches >= 22 already contain this fix. If the crash is still present with E24 then it must be a different source, can you provide crash dumps or steps to repro and open an issue ? Thanks!

Apologies was mistaken, the new VSCode Insiders does work properly now and it seems that Obsidian is on electron 22.3.3.

@deepak1556
Copy link
Member

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants