Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing 'cursor-changed' type values #38210

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Follow-up to #38183.

Adds missing cursor types and corrects a previous error.

Checklist

Release Notes

Notes: Added several new cursor values to the cursor-changed event.

@codebytere codebytere added semver/minor backwards-compatible functionality target/25-x-y PR should also be added to the "25-x-y" branch. labels May 8, 2023
@codebytere codebytere self-assigned this May 8, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels May 8, 2023
@codebytere codebytere removed their assignment May 8, 2023
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit e7fc1a4 into main May 15, 2023
16 checks passed
@codebytere codebytere deleted the update-cursor-types branch May 15, 2023 08:27
@release-clerk
Copy link

release-clerk bot commented May 15, 2023

Release Notes Persisted

Added several new cursor values to the cursor-changed event.

@trop
Copy link
Contributor

trop bot commented May 15, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels May 15, 2023
@codebytere
Copy link
Member Author

/trop run backport-to 25-x-y,24-x-y

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 25-x-y!

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 24-x-y!

@trop
Copy link
Contributor

trop bot commented May 17, 2023

I have automatically backported this PR to "25-x-y", please check out #38363

@trop
Copy link
Contributor

trop bot commented May 17, 2023

I have automatically backported this PR to "24-x-y", please check out #38364

@trop trop bot added in-flight/24-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/25-x-y in-flight/24-x-y labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants