fix: getNormalBounds() for transparent windows on Windows

[codebytere]

Description of Change

Closes #38180.

Fixes an issue where getNormalBounds() returns incorrect bounds when a BrowserWindow is transparent and maximized. The underlying logic in widget doesn't account well for the transparent case - this is something we already account for in other areas.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where getNormalBounds() returns incorrect bounds for transparent maximized windows on Windows.

[tomasmi]

I will have to point out that the fix is not going to work also if the window is minimized.
if (transparent() && (IsMaximized() || IsMinimized())) { return last_normal_bounds_dip_; }
We have our own fork of it and we were returning last normal bounds dip because
There was an issue with restore on Windows, that sometimes causes the Window to receive the wrong size

[codebytere]

@tomasmi interesting 🤔 i checked briefly with the window minimized and the result for getNormalBounds() after minimizing a transparent window showed for me on Windows 11 as correct:

console.log(mainWindow.getNormalBounds())
// { x: 560, y: 280, width: 800, height: 600 }

mainWindow.maximize()
console.log(mainWindow.getNormalBounds())
// { x: 560, y: 280, width: 800, height: 600 }

mainWindow.minimize()
console.log(mainWindow.getNormalBounds())
// { x: 560, y: 280, width: 800, height: 600 }

[dsanders11]

@codebytere, I think that's actually the inadvertent result of another bug with transparent windows, which is if you maximize a window, then minimize it, isMaximized returns true (https://gist.github.com/dsanders11/5bbe6026933faf96d7bcd5861bd51464), and so the code path in this PR gets taken when it otherwise wouldn't.

This PR doesn't cover the case of a fullscreen window, which suffers from the same bug as maximized.

Off the top of my head, I think some refactoring around restore_bounds_ could make this simpler. If it was made an absl::optional and cleared on unmaximize/unfullscreen, then the code change in this PR could be simplified to check if restore_bounds_ is set, and if so return that. Otherwise returning restore_bounds_ for the minimized state might return a stale value from a previous maximize.

[codebytere]

Once this is rebased on #38234 it should work as expected

Dismissing to rebase on top of #38234

[release-clerk]

Release Notes Persisted

Fixed an issue where getNormalBounds() returns incorrect bounds for transparent maximized windows on Windows.

[trop]

I have automatically backported this PR to "23-x-y", please check out #38347

[trop]

I have automatically backported this PR to "25-x-y", please check out #38348

[trop]

I have automatically backported this PR to "24-x-y", please check out #38349