Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only exit fullscreen conditionally with setKiosk #38219

Merged
merged 1 commit into from May 9, 2023
Merged

fix: only exit fullscreen conditionally with setKiosk #38219

merged 1 commit into from May 9, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Closes #38204.

Fixes an issue where calls to window.setKiosk(false) would exit fullscreen regardless of the fullscreen state prior to kiosk mode.

Checklist

Release Notes

Notes: Fixed an issue where calls to window.setKiosk(false) would exit fullscreen regardless of the fullscreen state prior to kiosk mode.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 9, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 9, 2023
@jkleinsc jkleinsc merged commit 13e309e into main May 9, 2023
17 checks passed
@jkleinsc jkleinsc deleted the fix-fullscreen-kiosk branch May 9, 2023 16:28
@release-clerk
Copy link

release-clerk bot commented May 9, 2023

Release Notes Persisted

Fixed an issue where calls to window.setKiosk(false) would exit fullscreen regardless of the fullscreen state prior to kiosk mode.

@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels May 9, 2023
@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels May 9, 2023
@trop
Copy link
Contributor

trop bot commented May 9, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels May 9, 2023
@electron electron deleted a comment from trop bot May 17, 2023
@electron electron deleted a comment from trop bot May 17, 2023
@electron electron deleted a comment from trop bot May 17, 2023
@electron electron deleted a comment from trop bot May 17, 2023
@codebytere
Copy link
Member Author

/trop run backport-to 25-x-y,24-x-y,23-x-y

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 25-x-y!

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 24-x-y!

@trop
Copy link
Contributor

trop bot commented May 17, 2023

The backport process for this PR has been manually initiated - sending your PR to 23-x-y!

@trop
Copy link
Contributor

trop bot commented May 17, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 17, 2023

I was unable to backport this PR to "23-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request May 17, 2023
Closed
@trop
Copy link
Contributor

trop bot commented May 17, 2023

I have automatically backported this PR to "25-x-y", please check out #38366

@codebytere codebytere mentioned this pull request May 17, 2023
Closed
@trop
Copy link
Contributor

trop bot commented May 17, 2023

@codebytere has manually backported this PR to "24-x-y", please check out #38367

@codebytere codebytere mentioned this pull request May 17, 2023
Closed
@trop
Copy link
Contributor

trop bot commented May 17, 2023

@codebytere has manually backported this PR to "23-x-y", please check out #38368

@trop trop bot removed the in-flight/25-x-y label Jun 15, 2023
@commit-lint commit-lint bot mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@miniak miniak Awaiting requested review from miniak

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Stay in fullscreen when leaving Kiosk mode
3 participants
@codebytere @zcbenz @jkleinsc