Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add USB protected classes handler #38263

Merged
merged 5 commits into from May 30, 2023
Merged

feat: add USB protected classes handler #38263

merged 5 commits into from May 30, 2023

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented May 11, 2023

Description of Change

Checklist

Release Notes

Notes: Added setUSBProtectedClassesHandler to allow access to protected USB classes with WebUSB.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 11, 2023
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label May 11, 2023
@codebytere codebytere self-requested a review May 12, 2023 09:40
docs/api/session.md Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 18, 2023
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

docs/api/session.md Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
@nikolaxmarkovic
Copy link

nikolaxmarkovic commented May 23, 2023

Would it be ok to port change to 24-x-y and\or 25-x-y since branches include #36289 ?

@jkleinsc jkleinsc added target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 24, 2023
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit b4ec363 into main May 30, 2023
18 checks passed
@jkleinsc jkleinsc deleted the add-usb-class-handler branch May 30, 2023 16:35
@release-clerk
Copy link

release-clerk bot commented May 30, 2023

Release Notes Persisted

Added setUSBProtectedClassesHandler to allow access to protected USB classes with WebUSB.

@trop
Copy link
Contributor

trop bot commented May 30, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels May 30, 2023
@trop
Copy link
Contributor

trop bot commented May 30, 2023

I have automatically backported this PR to "25-x-y", please check out #38493

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels May 30, 2023
jkleinsc added a commit that referenced this pull request May 30, 2023
* feat: add USB protected classes handler

* chore: apply review suggestions

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: update docs

* chore: apply review suggestions

* update doc per suggestion

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit b4ec363)
@trop
Copy link
Contributor

trop bot commented May 30, 2023

@jkleinsc has manually backported this PR to "24-x-y", please check out #38498

@trop trop bot added in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch and removed needs-manual-bp/24-x-y in-flight/24-x-y labels May 30, 2023
jkleinsc added a commit that referenced this pull request Jun 1, 2023
feat: add USB protected classes handler (#38263)

* feat: add USB protected classes handler

* chore: apply review suggestions

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: update docs

* chore: apply review suggestions

* update doc per suggestion

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit b4ec363)
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants