Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isMaximized after minimize/fullscreen on macOS #38291

Merged
merged 1 commit into from May 16, 2023
Merged

fix: isMaximized after minimize/fullscreen on macOS #38291

merged 1 commit into from May 16, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 15, 2023 •
edited

Description of Change

When an NSWindow is initially minimized on macOS, it's possible for [window_ isZoomed] to be true
when the window is minimized or fullscreened. This adds an explicit guard to fix that, thereby matching Chromium behavior.

See #38234 (comment)

Checklist

Release Notes

Notes: Fixed an issue where BrowserWindow.isMaximized() could incorrectly return true for minimized or fullscreened windows on macOS.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 15, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 15, 2023
@codebytere codebytere requested a review from jkleinsc May 15, 2023 09:27
@codebytere codebytere merged commit 042663e into main May 16, 2023
20 checks passed
@codebytere codebytere deleted the max-to-min-mac branch May 16, 2023 07:26
@release-clerk
Copy link

release-clerk bot commented May 16, 2023

Release Notes Persisted

Fixed an issue where BrowserWindow.isMaximized() could incorrectly return true for minimized or fullscreened windows on macOS.

@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label May 16, 2023
@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "23-x-y", please check out #38306

@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop trop bot removed the target/23-x-y PR should also be added to the "23-x-y" branch. label May 16, 2023
@trop trop bot mentioned this pull request May 16, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "25-x-y", please check out #38307

@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "24-x-y", please check out #38308

@trop trop bot added in-flight/25-x-y in-flight/24-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/25-x-y labels May 16, 2023
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/24-x-y labels May 16, 2023
@commit-lint commit-lint bot mentioned this pull request Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @dsanders11