Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MediaDevices missing DisplayMediaInformation #38390

Merged
merged 1 commit into from May 24, 2023
Merged

fix: MediaDevices missing DisplayMediaInformation #38390

merged 1 commit into from May 24, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Closes #38381.

Fixes an issue where MediaStreamTrack.getCaptureHandle() always returned null. This was happening because we were not properly setting display_media_info on each blink::MediaStreamDevice in our permission handling.

Verified with https://gist.github.com/t57ser/919ff9c9fe623b51fde41772bf4c9207

Checklist

Release Notes

Notes: Fixed an issue where MediaStreamTrack.getCaptureHandle() always returned null.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 22, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 22, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2023
@jkleinsc jkleinsc merged commit 16cd486 into main May 24, 2023
16 checks passed
@jkleinsc jkleinsc deleted the fix-media-capture-handle branch May 24, 2023 15:17
@release-clerk
Copy link

release-clerk bot commented May 24, 2023

Release Notes Persisted

Fixed an issue where MediaStreamTrack.getCaptureHandle() always returned null.

This was referenced May 24, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 24, 2023

I have automatically backported this PR to "25-x-y", please check out #38433

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels May 24, 2023
@trop
Copy link
Contributor

trop bot commented May 24, 2023

I have automatically backported this PR to "24-x-y", please check out #38434

@trop trop bot added in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/24-x-y in-flight/25-x-y labels May 24, 2023
@commit-lint commit-lint bot mentioned this pull request Aug 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: getCaptureHandle not working
2 participants
@codebytere @jkleinsc