Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove enable_desktop_capturer flag #38412

Merged
merged 1 commit into from May 24, 2023
Merged

build: remove enable_desktop_capturer flag #38412

merged 1 commit into from May 24, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 23, 2023 •
edited

Description of Change

Disabling enable_desktop_capturer only saves around 40 KB in the generated binaries.

Checklist

Release Notes

Notes: The enable_desktop_capturer build flag has been removed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2023
@miniak miniak added semver/minor backwards-compatible functionality no-backport labels May 23, 2023
@miniak miniak self-assigned this May 23, 2023
@miniak miniak added semver/major incompatible API changes and removed semver/minor backwards-compatible functionality labels May 23, 2023
@miniak miniak marked this pull request as ready for review May 23, 2023 20:45
@miniak miniak force-pushed the miniak/enable_desktop_capturer branch from 82bb387 to 3bb670a Compare May 23, 2023 20:45
deepak1556
deepak1556 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the size savings are not significant and the dependency has not changed for a long time.

@miniak
Copy link
Contributor Author

miniak commented May 24, 2023

@codebytere which semver category should this be? also should it be build: instead of feat:?

@miniak miniak changed the title feat: remove enable_desktop_capturer flag build: remove enable_desktop_capturer flag May 24, 2023
@electron-cation electron-cation bot added semver/none and removed new-pr 🌱 PR opened in the last 24 hours labels May 24, 2023
@miniak miniak added new-pr 🌱 PR opened in the last 24 hours and removed api-review/requested 🗳 labels May 24, 2023
@electron-cation electron-cation bot added api-review/requested 🗳 and removed new-pr 🌱 PR opened in the last 24 hours labels May 24, 2023
@miniak miniak added new-pr 🌱 PR opened in the last 24 hours and removed semver/major incompatible API changes labels May 24, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 24, 2023
@miniak miniak added new-pr 🌱 PR opened in the last 24 hours and removed api-review/requested 🗳 labels May 24, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 24, 2023
@jkleinsc jkleinsc merged commit 06cc9ca into main May 24, 2023
19 checks passed
@jkleinsc jkleinsc deleted the miniak/enable_desktop_capturer branch May 24, 2023 19:32
@release-clerk
Copy link

release-clerk bot commented May 24, 2023

Release Notes Persisted

The enable_desktop_capturer build flag has been removed.

JuanIrache added a commit to JuanIrache/remote that referenced this pull request Jun 1, 2023
@JuanIrache
Checking isDesktopCapturerEnabled is no longer necessary or possible. F…
10e02d5 
…ixes electron#153

Context electron/electron#38412
codebytere pushed a commit to electron/remote that referenced this pull request Jun 5, 2023
@JuanIrache
fix: prevent checking isDesktopCapturerEnabled, which crashes on elec…
9f543a1 
…tron@26 (#154)

* Avoid crash with electron 26

Not sure of the side effects of this

* Checking isDesktopCapturerEnabled is no longer necessary or possible. Fixes #153

Context electron/electron#38412

* Revert to checking isDesktopCapturerEnabled for pre-26 electron versions
@commit-lint commit-lint bot mentioned this pull request Aug 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @jkleinsc @deepak1556 @codebytere