build: remove enable_run_as_node build flag #38413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/enable_run_as_node
branch
from
0bc8003
to
8cdc581
Compare
miniak
changed the title
electron-cation
bot
added
semver/none
and removed
new-pr 🌱
miniak
added
new-pr 🌱
miniak
added
semver/patch
deepak1556
reviewed
Jun 8, 2023
| @@ -22,10 +21,6 @@ bool IsPDFViewerEnabled() { | |||
| return BUILDFLAG(ENABLE_PDF_VIEWER); | |||
| } | |||
|
|
|||
| bool IsRunAsNodeEnabled() { | |||
| return electron::fuses::IsRunAsNodeEnabled() && BUILDFLAG(ENABLE_RUN_AS_NODE); | |||
There was a problem hiding this comment.
I think this the feature api is still needed so that tests can be excluded based on the fuse value ?
There was a problem hiding this comment.
we don't have infra to test different fuse values unfortunately right now, it would make sense to add that as none of the other fuses are being tested
deepak1556
approved these changes
Jun 8, 2023
|
Release Notes Persisted
|
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: remove enable_run_as_node flag * drop features.isRunAsNodeEnabled() * use IsEnvSet() helper in electron_main_linux.cc * cleanup [[maybe_unused]] --------- Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We don't need the buildflag anymore now that we have https://github.com/electron/electron/blob/main/docs/tutorial/fuses.md#runasnode
Checklist
npm testpassesRelease Notes
Notes: The
enable_run_as_nodebuild flag has been removed in favor of therunAsNodefuse.