fix: DCHECK minimizing parent window with non-modal child #38460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
ckerr
approved these changes
May 25, 2023
dsanders11
approved these changes
May 25, 2023
codebytere
force-pushed
the
fix-dcheck
branch
3 times, most recently
from
bca9121
to
31bcd81
Compare
ckerr
reviewed
May 30, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "23-x-y", please check out #38507 |
trop
bot
removed
the
target/23-x-y
|
I have automatically backported this PR to "24-x-y", please check out #38508 |
|
I have automatically backported this PR to "25-x-y", please check out #38509 |
trop
bot
added
in-flight/24-x-y
in-flight/25-x-y
merged/25-x-y
tzahola
reviewed
Nov 16, 2023
| // save and restore it afterwards. | ||
| NSInteger level = window_.level; | ||
| [window_ addChildWindow:child_nswindow ordered:NSWindowAbove]; | ||
| [window_ setLevel:level]; |
There was a problem hiding this comment.
In the original code, it was the child window's level that had to be restored, but here we're doing it on the parent.
This change wasn't intentional, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #38459.
NativeWidgetNSWindowBridge::NotifyVisibilityChangeDown()expects that the parent window's children have all been hidden before the window is hidden, or there is a DCHECK. This fixes that.We previously solved something similar in #29821 - however, here, we can't just detach the windows. The children need to reappear when the window becomes visible again, so we instead need to add some mechanics to hide and restore windows appropriately. I took my cue upstream from
components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm- which has these same mechanics for similar reasons.Checklist
npm testpassesRelease Notes
Notes: Fixed potential issues when minimizing parent windows with non-modal children on macOS.