Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Windows FrameView always appearing inactive #38468

Merged
merged 1 commit into from May 28, 2023
Merged

fix: Windows FrameView always appearing inactive #38468

merged 1 commit into from May 28, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 27, 2023 •
edited

Description of Change

Closes #38385.
Refs CL:4435695.

Fixes an issue where Windows FrameViews always appeared inactive regardless of focus status. This was happening because Chromium added extra plumbing to set active state as a function of whether or not in delegate_->ShouldPaintAsActive(); was true in HWNDMessageHandler::PaintAsActiveChanged(), and we'd overridden it to return false.

Confirmed not to regress #24647.

Checklist

Release Notes

Notes: Fixes an issue where Windows FrameViews always appeared inactive regardless of focus status.

@codebytere codebytere requested a review from zcbenz May 27, 2023 15:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2023
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels May 27, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2023
@codebytere codebytere marked this pull request as ready for review May 28, 2023 08:04
VerteDinde
VerteDinde approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@jkleinsc jkleinsc merged commit 56138d8 into main May 28, 2023
18 checks passed
@jkleinsc jkleinsc deleted the fix-inactive-titlebar-win branch May 28, 2023 22:39
@release-clerk
Copy link

release-clerk bot commented May 28, 2023

Release Notes Persisted

Fixes an issue where Windows FrameViews always appeared inactive regardless of focus status.

@trop trop bot mentioned this pull request May 28, 2023
Merged
@trop
Copy link
Contributor

trop bot commented May 28, 2023

I have automatically backported this PR to "25-x-y", please check out #38473

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/25-x-y labels May 28, 2023
@dsanders11 dsanders11 mentioned this pull request Jul 30, 2023
Merged
2 tasks
@commit-lint commit-lint bot mentioned this pull request Aug 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@dsanders11 dsanders11 Awaiting requested review from dsanders11

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Windows look inactive when they're focused on Windows
3 participants
@codebytere @jkleinsc @VerteDinde