Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use node scheme imports in spec #38487

Merged
merged 1 commit into from
Jun 15, 2023
Merged

refactor: use node scheme imports in spec #38487

merged 1 commit into from
Jun 15, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 30, 2023 •
edited

Description of Change

First part of the move to the node: scheme imports
https://stateful.com/blog/node-18-prefix-only-modules

Unblocked by #38472, #38567 and #38742

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 30, 2023
@miniak
Copy link
Contributor Author

miniak commented May 30, 2023 •
edited

@jkleinsc can we use node 16 in the build?

error eslint-plugin-unicorn@47.0.0: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.18.3"

@miniak miniak self-assigned this May 30, 2023
@miniak miniak force-pushed the miniak/node-scheme-imports-spec branch from 4712892 to ff24196 Compare May 30, 2023 11:49
@miniak miniak marked this pull request as ready for review May 30, 2023 12:45
@miniak miniak marked this pull request as draft May 30, 2023 20:08
@miniak miniak force-pushed the miniak/node-scheme-imports-spec branch from fe74340 to 820204f Compare May 31, 2023 10:31
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 31, 2023
@miniak miniak force-pushed the miniak/node-scheme-imports-spec branch from 820204f to 7624b79 Compare June 3, 2023 02:45
@jkleinsc
Copy link
Contributor

jkleinsc commented Jun 8, 2023

@jkleinsc can we use node 16 in the build?

error eslint-plugin-unicorn@47.0.0: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.18.3"

@miniak which CI/where are you seeing this error?

@miniak miniak force-pushed the miniak/node-scheme-imports-spec branch 3 times, most recently from f513e5c to 6b99e2b Compare June 12, 2023 10:57
@miniak miniak force-pushed the miniak/node-scheme-imports-spec branch from 6b99e2b to 8b50a14 Compare June 14, 2023 09:08
@miniak
Copy link
Contributor Author

miniak commented Jun 14, 2023

@jkleinsc I don't remember unfortunately, I ended up using an older version of the package, which still works with node 14 for now.

@miniak miniak marked this pull request as ready for review June 14, 2023 11:43
@miniak miniak requested a review from dsanders11 June 14, 2023 11:43
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2023
@jkleinsc jkleinsc merged commit d78f37e into main Jun 15, 2023
15 checks passed
@jkleinsc jkleinsc deleted the miniak/node-scheme-imports-spec branch June 15, 2023 14:42
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2023

No Release Notes

This was referenced Jun 19, 2023
Merged
Merged
Closed
@miniak miniak mentioned this pull request Jul 15, 2023
Merged
@commit-lint commit-lint bot mentioned this pull request Sep 7, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
refactor: use node scheme imports in spec (electron#38487)
c16f8d4 
Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @jkleinsc @dsanders11