Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make contentTracing.stopRecording() failure clearer #38488

Merged
merged 1 commit into from May 31, 2023
Merged

chore: make contentTracing.stopRecording() failure clearer #38488

merged 1 commit into from May 31, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Reject with a more descriptive error when contentTracing.stopRecording() fails because no trace was in progress.

Checklist

Release Notes

Notes: Improve error message when contentTracing.stopRecording() fails because no trace was in progress.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 30, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 30, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 31, 2023
@jkleinsc jkleinsc merged commit 663497d into main May 31, 2023
17 checks passed
@jkleinsc jkleinsc deleted the content-tracing-stop-clearer branch May 31, 2023 13:54
@release-clerk
Copy link

release-clerk bot commented May 31, 2023

Release Notes Persisted

Improve error message when contentTracing.stopRecording() fails because no trace was in progress.

This was referenced May 31, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "23-x-y", please check out #38518

@trop trop bot added in-flight/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels May 31, 2023
@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "25-x-y", please check out #38519

@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "24-x-y", please check out #38520

@trop trop bot added in-flight/25-x-y in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/24-x-y in-flight/25-x-y labels May 31, 2023
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/23-x-y labels Jun 5, 2023
@commit-lint commit-lint bot mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @deepak1556