New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick 0e1cc35 from v8 #38490
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I have automatically backported this PR to "25-x-y", please check out #38510 |
I have automatically backported this PR to "22-x-y", please check out #38511 |
I have automatically backported this PR to "24-x-y", please check out #38512 |
I have automatically backported this PR to "23-x-y", please check out #38513 |
Thanks all! ❤️ |
Description of Change
This PR adds a v8 patch to address this issue: electron/mksnapshot#91
This issue was corrected in v8 version 11.6.21 in CL: https://chromium-review.googlesource.com/c/v8/v8/+/4547712
I've added this patch in an effort to get this fix sooner and potentially in older versions of electron as well.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where mksnapshot would crash with a sigbus error.