Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 0e1cc35 from v8 #38490

Merged
merged 3 commits into from May 31, 2023
Merged

chore: cherry-pick 0e1cc35 from v8 #38490

merged 3 commits into from May 31, 2023

Conversation

mjhenkes
Copy link
Contributor

@mjhenkes mjhenkes commented May 30, 2023

Description of Change

This PR adds a v8 patch to address this issue: electron/mksnapshot#91

This issue was corrected in v8 version 11.6.21 in CL: https://chromium-review.googlesource.com/c/v8/v8/+/4547712

I've added this patch in an effort to get this fix sooner and potentially in older versions of electron as well.

Checklist

Release Notes

Notes: Fixed an issue where mksnapshot would crash with a sigbus error.

@mjhenkes mjhenkes requested a review from a team as a code owner May 30, 2023 15:00
@welcome
Copy link

welcome bot commented May 30, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 30, 2023
@deepak1556 deepak1556 changed the title fix: v8 patch mksnapshot to "Set proper instruction start for builtins" chore: cherry-pick 0e1cc35 from v8 May 30, 2023
@jkleinsc jkleinsc added the target/22-x-y PR should also be added to the "22-x-y" branch. label May 30, 2023
@codebytere codebytere merged commit 2c742cf into electron:main May 31, 2023
19 checks passed
@welcome
Copy link

welcome bot commented May 31, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented May 31, 2023

Release Notes Persisted

Fixed an issue where mksnapshot would crash with a sigbus error.

@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "25-x-y", please check out #38510

@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "22-x-y", please check out #38511

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label May 31, 2023
@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "24-x-y", please check out #38512

@trop
Copy link
Contributor

trop bot commented May 31, 2023

I have automatically backported this PR to "23-x-y", please check out #38513

@trop trop bot added in-flight/24-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels May 31, 2023
@mjhenkes
Copy link
Contributor Author

Thanks all! ❤️

@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y in-flight/24-x-y labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants