fix: navigator.connection not working as intended
#38491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
deepak1556
approved these changes
May 30, 2023
ckerr
reviewed
May 30, 2023
ckerr
approved these changes
May 30, 2023
codebytere
force-pushed
the
fix-navigator-connection
branch
from
5e8d77c
to
3e4ab38
Compare
jkleinsc
approved these changes
May 31, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
removed
the
target/25-x-y
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/23-x-y
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/23-x-y
needs-manual-bp/24-x-y
and removed
target/24-x-y
ckerr
pushed a commit
that referenced
this pull request
Jun 22, 2023
* fix: navigator.connection not working as intended * chore: make network quality methods private
trop
bot
added
in-flight/25-x-y
merged/25-x-y
codebytere
added a commit
that referenced
this pull request
Jun 23, 2023
fix: `navigator.connection` not working as intended (#38491) * fix: navigator.connection not working as intended * chore: make network quality methods private Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
|
@codebytere has manually backported this PR to "24-x-y", please check out #39100 |
trop
bot
added
in-flight/24-x-y
merged/24-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #38484.
Fixes an issue where
navigator.connectionreturned incorrect data. This was happening because we never set up the observer plumbing to set the correct values.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
navigator.connectionreturned incorrect data.