Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow customizing the default math font #38514

Merged
merged 1 commit into from
Jun 6, 2023
Merged

feat: Allow customizing the default math font #38514

merged 1 commit into from
Jun 6, 2023

Conversation

zeeker999
Copy link
Contributor

Description of Change

Added math option to defaultFontFamily in webPreferences to allow customization of the default math font along with other fonts.

Checklist

Release Notes

Notes: Added support for customization of the default math font along with other fonts.

@zcbenz @deepak1556

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 31, 2023
@zeeker999 zeeker999 changed the title feat: Allow customzing the default math font feat: Allow customizing the default math font May 31, 2023
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label May 31, 2023
zcbenz
zcbenz approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

codebytere
codebytere approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc added api-review/approved ✅ and removed new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Jun 6, 2023
erickzhao
erickzhao approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

erickzhao
erickzhao approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc
Copy link
Contributor

jkleinsc commented Jun 6, 2023

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 28332c9 into electron:main Jun 6, 2023
13 of 14 checks passed
@release-clerk
Copy link

release-clerk bot commented Jun 6, 2023

Release Notes Persisted

Added support for customization of the default math font along with other fonts.

@commit-lint commit-lint bot mentioned this pull request Aug 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zeeker999 @jkleinsc @zcbenz @codebytere @erickzhao @deepak1556