New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: child window may have opener removed #38910
Conversation
Release Notes Persisted
|
I have automatically backported this PR to "26-x-y", please check out #38930 |
I have automatically backported this PR to "25-x-y", please check out #38931 |
I have automatically backported this PR to "24-x-y", please check out #38932 |
I have automatically backported this PR to "23-x-y", please check out #38933 |
Description of Change
When handling node integration in child windows opened by
window.open
, the code assumed the child window's web frame must have aopener
, which is not correct since theopener
may be set to null.Close #38844.
Checklist
npm test
passesRelease Notes
Notes: Fix
preload
script may not run in some child windows opened bywindow.open
.