fix: filter exceptions passed to blink message handler #38912
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a partial fix for #37404.
Blink installs a global V8 message handler to print exceptions to devtools, which will crash when seeing an exception from a foreign context. Since we can not prevent Node from using a non-blink context (from
vm
module, or from native modules, or from Node's internal code), we should add a wrapper to prevent blink from accessing foreign contexts in the message handler.Checklist
npm test
passesRelease Notes
Notes: Fix crash when throwing exception from context created by Node.js
vm
module.