revert: compensate for title bar height when setting bounds on BrowserView
#38981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erView` This reverts commit 75f9573.
codebytere
added
semver/patch
electron-cation
bot
added
new-pr 🌱
jkleinsc
approved these changes
Jul 5, 2023
zcbenz
approved these changes
Jul 6, 2023
|
Release Notes Persisted
|
This was referenced Jul 6, 2023
|
I have automatically backported this PR to "26-x-y", please check out #39004 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "25-x-y", please check out #39005 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
|
Oh wow, thank you for the fix! |
trop
bot
added
merged/25-x-y
PalmerAL
added a commit
to minbrowser/min
that referenced
this pull request
Oct 19, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…erView` (electron#38981) This reverts commit 75f9573.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35994.
Refs #34713.
This reverts 75f9573. We can look towards a better solution in the future but for now I think it's better than behavior is consistent cross-platform.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where setting bounds on
BrowserViewscan behave inconsistently across platforms.