Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated ipcRenderer.sendTo() #39087

Merged
merged 1 commit into from Aug 28, 2023
Merged

chore: remove deprecated ipcRenderer.sendTo() #39087

merged 1 commit into from Aug 28, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 13, 2023 •
edited by ckerr

Description of Change

Follow-up to #39091

Checklist

Release Notes

Notes: Removed deprecated ipcRenderer.sendTo().

@miniak miniak added semver/major incompatible API changes wip ⚒ no-backport labels Jul 13, 2023
@miniak miniak self-assigned this Jul 13, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Jul 13, 2023
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from dc373c1 to ca5457e Compare July 13, 2023 18:25
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 20, 2023
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch 3 times, most recently from ca17377 to 8869caf Compare July 24, 2023 13:50
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from 8869caf to 28e2a03 Compare August 7, 2023 10:32
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from 28e2a03 to 5ecb8a1 Compare August 14, 2023 22:12
@miniak miniak marked this pull request as ready for review August 16, 2023 19:45
@miniak miniak requested a review from a team as a code owner August 16, 2023 19:45
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from 5ecb8a1 to ad0b0b3 Compare August 16, 2023 19:45
@miniak miniak removed the wip ⚒ label Aug 16, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2023
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from ad0b0b3 to 180143d Compare August 16, 2023 21:12
@miniak miniak requested a review from dsanders11 August 17, 2023 09:23
@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch 2 times, most recently from e6be100 to e387aa3 Compare August 21, 2023 14:55
@electron-cation
Copy link

electron-cation bot commented Aug 21, 2023 •
edited by dsanders11

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

@miniak miniak force-pushed the miniak/remove-ipc-renderer-send-to branch from e387aa3 to 146ed45 Compare August 22, 2023 09:03
@codebytere codebytere changed the title chore: remove deprecated ipcRenderer.sendTo() chore: remove deprecated ipcRenderer.sendTo() Aug 22, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2023
dsanders11
dsanders11 requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a block on merging this just because I need to use it to finish debugging a cation issue with the deprecation review feat - will remove the requested changes by EOW. 🙇

dsanders11
dsanders11 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cation issue debugged, LGTM. 👍

@miniak
Copy link
Contributor Author

miniak commented Aug 28, 2023

@codebytere, @dsanders11 is there anything preventing us from merging this PR (apart from the missing API LGTMs)?

jkleinsc
jkleinsc approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit 5078cae into main Aug 28, 2023
18 of 19 checks passed
@jkleinsc jkleinsc deleted the miniak/remove-ipc-renderer-send-to branch August 28, 2023 14:29
@release-clerk
Copy link

release-clerk bot commented Aug 28, 2023 •
edited by ckerr

Release Notes Persisted

Removed deprecated ipcRenderer.sendTo().

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: remove deprecated ipcRenderer.sendTo() (electron#39087)
7c88f1d 
chore: remove deprecated ipcRenderer.sendTo()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

@miniak miniak

Labels
api-review/approved ✅ deprecation-review/complete ✅ no-backport semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @jkleinsc @codebytere @dsanders11