Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS tray button selection with VoiceOver #39352

Merged
merged 1 commit into from Aug 7, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 3, 2023

Description of Change

Closes #21062.

Fixes an accessibility issue where VoiceOver couldn't trigger the tray action when selected to emit the click event. This was happening because the NSStatusBarButton had no action or target, and since voiceover selection is not a mouseEvent, it wouldn't trigger mouseDown or mouseUp.

To correct this, we set a target and action for the button. We also need to create a synthetic event if we're triggering the click event via VoiceOver.

Tested with https://gist.github.com/oysteinmoseng/bec736b1c2ceec3fa6e5a77d46d3ac08 (and, of course, VoiceOver)

Checklist

Release Notes

Notes: Fixes an accessibility issue where VoiceOver couldn't trigger the tray action when selected to emit the click event.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 3, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 4, 2023
@codebytere codebytere merged commit dc707ee into main Aug 7, 2023
18 checks passed
@codebytere codebytere deleted the fix-voiceover-selection branch August 7, 2023 07:52
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2023

Release Notes Persisted

Fixes an accessibility issue where VoiceOver couldn't trigger the tray action when selected to emit the click event.

@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/24-x-y PR should also be added to the "24-x-y" branch. label Aug 7, 2023
@trop
Copy link
Contributor

trop bot commented Aug 7, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y needs-manual-bp/25-x-y needs-manual-bp/26-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 7, 2023
@trop
Copy link
Contributor

trop bot commented Aug 9, 2023

@codebytere has manually backported this PR to "26-x-y", please check out #39439

@trop trop bot added in-flight/24-x-y in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/25-x-y in-flight/24-x-y labels Aug 9, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to click tray icon with VoiceOver
3 participants