New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: macOS tray button selection with VoiceOver #39352
Conversation
8d1b6f8
to
eecd14a
Compare
Release Notes Persisted
|
I was unable to backport this PR to "24-x-y" cleanly; |
I was unable to backport this PR to "25-x-y" cleanly; |
I was unable to backport this PR to "26-x-y" cleanly; |
@codebytere has manually backported this PR to "26-x-y", please check out #39439 |
Description of Change
Closes #21062.
Fixes an accessibility issue where
VoiceOver
couldn't trigger the tray action when selected to emit the click event. This was happening because theNSStatusBarButton
had no action or target, and since voiceover selection is not amouseEvent
, it wouldn't triggermouseDown
ormouseUp
.To correct this, we set a target and action for the button. We also need to create a synthetic event if we're triggering the click event via VoiceOver.
Tested with https://gist.github.com/oysteinmoseng/bec736b1c2ceec3fa6e5a77d46d3ac08 (and, of course, VoiceOver)
Checklist
npm test
passesRelease Notes
Notes: Fixes an accessibility issue where
VoiceOver
couldn't trigger the tray action when selected to emit the click event.