feat: support chrome.scripting extension APIs
#39395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
codebytere
force-pushed
the
chrome-scripting
branch
2 times, most recently
from
ad0243c
to
762d1ce
Compare
3 tasks
codebytere
force-pushed
the
chrome-scripting
branch
3 times, most recently
from
385065d
to
f3577e1
Compare
codebytere
added
target/25-x-y
codebytere
force-pushed
the
chrome-scripting
branch
from
9998354
to
f3577e1
Compare
codebytere
force-pushed
the
chrome-scripting
branch
from
f3577e1
to
21286cf
Compare
github-actions
bot
added
the
target/27-x-y
codebytere
force-pushed
the
chrome-scripting
branch
from
21286cf
to
564ab5c
Compare
codebytere
force-pushed
the
chrome-scripting
branch
from
564ab5c
to
a9e1472
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
This was referenced Aug 28, 2023
|
I have automatically backported this PR to "27-x-y", please check out #39675 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39676 |
|
I have automatically backported this PR to "25-x-y", please check out #39677 |
trop
bot
added
in-flight/26-x-y
in-flight/25-x-y
and removed
target/26-x-y
trop
bot
added
merged/27-x-y
3 tasks
trop
bot
added
merged/26-x-y
|
@codebytere Is there a list of what V3 APIs are currently supported? I have looked around but have yet to be able to locate it. |
|
@jasonfill i've tried to tune up this doc to reflect current support - what would help that doc be more effective for you? |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
feat: support chrome.scripting extension APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37876.
This PR adds support for
chrome.scripting.From reference docs:
This represents an important step towards proper support of Manifest V3. Specifically -
chrome.scriptingsupersedeschrome.tabs.executeScript, which is gone in Manifest V3. It's commonly used in several DevTools extensions, including React DevTools.The source code added here is essentially unchanged from upstream - we need to add it to our api definitions because it lives upstream in
chrome/browser/extensions/api, which we do not depend on (and shouldn't, since many of the api implementations therein involve concepts not transferable to Electron without significant modification).Checklist
npm testpassesRelease Notes
Notes: Added support for
chrome.scriptingextension APIs.