New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow headers to be sent with webContents.downloadURL()
#39455
Conversation
webContents.downloadURL()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
1b04fd5
to
ee47fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM.
One small doc comment, we've now got three identical options
structs in the docs. Candidate for a new addition to docs/api/structures/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
ee47fd6
to
ed2177f
Compare
Release Notes Persisted
|
I have automatically backported this PR to "27-x-y", please check out #39560 |
I have automatically backported this PR to "25-x-y", please check out #39561 |
I have automatically backported this PR to "26-x-y", please check out #39562 |
…tron#39455) feat: allow headers to be sent with webContents.downloadURL()
…tron#39455) feat: allow headers to be sent with webContents.downloadURL()
Description of Change
Refs #38785.
There's no reason that the API signatures for these methods shouldn't be identical, and it's arguably more confusing for users that they're not, given they both trigger
will-download
onsession
.NOTE: The bulk of this change is test changes and additions - the code change is minimal and identical to what was changed in #38785.
Caught when cleaning up some tests.
Checklist
npm test
passesRelease Notes
Notes: Added the ability to send HTTP headers with
webContents.downloadURL()
.