Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explorer restart does not recreated thumbnail toolbar buttons #39551

Merged
merged 1 commit into from Aug 21, 2023
Merged

fix: explorer restart does not recreated thumbnail toolbar buttons #39551

merged 1 commit into from Aug 21, 2023

Conversation

tr2-harada
Copy link
Contributor

@tr2-harada tr2-harada commented Aug 17, 2023 •
edited

Description of Change

Problem

When explorer restarted, it didn't regenerate the thumbnail toolbar button, so the button was removed.
Also, BrowserWindow.setThumbarButtons prevented adding buttons because TaskbarHost.thumbar_buttons_added_ was true.

Fixes

Restore thumbnail toolbar buttons when receiving "TaskbarCreated" message in NativeWindowViews class.
closes #39550

Checklist

Release Notes

Notes: Fixed to regenerate thumbnail toolbar buttons when explorer is restarted.

@welcome
Copy link

welcome bot commented Aug 17, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2023
@tr2-harada tr2-harada changed the title fix: explorer restart does not recreated thumbnail toolbar buttons. fix: explorer restart does not recreated thumbnail toolbar buttons Aug 17, 2023
@codebytere codebytere self-requested a review August 17, 2023 08:11
codebytere
codebytere approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://gist.github.com/4c883bfd2b1b593894d9dc096b93f0da and confirmed to solve the issue on my Windows machine.

Also confirmed that this approach is used upstream: https://codereview.chromium.org/6289010

Thanks for fixing this!

@codebytere codebytere added target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. semver/patch backwards-compatible bug fixes labels Aug 17, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2023
@zcbenz zcbenz merged commit 9937a2b into electron:main Aug 21, 2023
24 checks passed
@welcome
Copy link

welcome bot commented Aug 21, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023 •
edited by ckerr

Release Notes Persisted

Fixed regeneration of thumbnail toolbar buttons after restarting Explorer on Windows.

This was referenced Aug 21, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "24-x-y", please check out #39585

@trop trop bot mentioned this pull request Aug 21, 2023
Merged
@trop trop bot removed the target/24-x-y PR should also be added to the "24-x-y" branch. label Aug 21, 2023
@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "25-x-y", please check out #39586

@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "26-x-y", please check out #39587

@trop trop bot added in-flight/25-x-y in-flight/26-x-y merged/26-x-y PR was merged to the "26-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/26-x-y labels Aug 21, 2023
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/25-x-y in-flight/24-x-y labels Aug 21, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@tr2-harada
fix: explorer restart does not recreated thumbnail toolbar buttons (e…
5067212 
…lectron#39551)

fix: explorer restart does not recreated thumbnail toolbar buttons.
@commit-lint commit-lint bot mentioned this pull request Nov 10, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@tr2-harada
fix: explorer restart does not recreated thumbnail toolbar buttons (e…
4a2aa39 
…lectron#39551)

fix: explorer restart does not recreated thumbnail toolbar buttons.
@tr2-harada tr2-harada deleted the fix-thumbar-buttons-taskbar-created branch January 9, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Thumbnail toolbar buttons are removed when Explorer is restarted
3 participants
@tr2-harada @zcbenz @codebytere