Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 5 changes from Release-0-M116 #39558

Merged
merged 3 commits into from Aug 21, 2023

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Aug 17, 2023

electron/security#389 - 8ff63d378f2c from v8 Merged: [builtins] Clear FixedArray slot in Promise builtins

Fixed: chromium:1468943
(cherry picked from commit a84849ed718932b94dc877bb44a2d38eb8a0aef9)

Change-Id: Ia2b181c373c15bd1840e2a1572c0e930cddcd788
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4753495
Commit-Queue: Adam Klein adamk@chromium.org
Reviewed-by: Adam Klein adamk@chromium.org
Auto-Submit: Shu-yu Guo syg@chromium.org
Cr-Commit-Position: refs/branch-heads/11.6@{#28}
Cr-Branched-From: e29c028f391389a7a60ee37097e3ca9e396d6fa4-refs/heads/11.6.189@{#3}
Cr-Branched-From: 95cbef20e2aa556a1ea75431a48b36c4de6b9934-refs/heads/main@{#88340}

electron/security#393 - 5486190be556 from angle [M114-LTS] Fix read size validation for RGBX formats.

GL_RGBX8_ANGLE is the only format where the upload format is 3-channel
RGB, whilethe download format is 4-channel RGBX. As such, the internal
format corresponding to format+type expects 3-byte input/output. The
format is fixed here for readPixels to output 4 bytes per pixel.

Bug: chromium:1458046
Change-Id: Iec737ed64bade003cfab50dc5f595eb4875e81e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706957
Commit-Queue: Shahbaz Youssefi syoussefi@chromium.org
(cherry picked from commit 430a4f559cbc2bcd5d026e8b36ee46ddd80e9651)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4765136
Commit-Queue: Daniel Yip danielyip@google.com
Auto-Submit: Daniel Yip danielyip@google.com
(cherry picked from commit 4a372ad49ceddea6c13f79adb212a777ec770a66)

electron/security#394 - d671b099a57d from v8 Merged: [compiler] check for read-only property on AccessMode::kDefine

(cherry picked from commit 95eda07ddbc1839e39b3d1ff5db329c0ceb6dfaa)

Change-Id: Ic5799a32e7c312e41cd0a7e1e6073a235414d56f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4665588
Auto-Submit: Tobias Tebbi tebbi@chromium.org
Reviewed-by: Darius Mercadier dmercadier@chromium.org
Commit-Queue: Darius Mercadier dmercadier@chromium.org
Cr-Commit-Position: refs/branch-heads/11.4@{#53}
Cr-Branched-From: 8a8a1e7086dacc426965d3875914efa66663c431-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e816e0bbce865cbbc3fa0ab357e6330bab-refs/heads/main@{#87241}

Notes:

* 8ff63d378f2c from v8
* 5486190be556 from angle
* d671b099a57d from v8
@ppontes ppontes requested a review from a team as a code owner August 17, 2023 12:17
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 24-x-y labels Aug 17, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 17, 2023
@ppontes ppontes marked this pull request as draft August 17, 2023 12:20
@ppontes ppontes changed the title chore: cherry-pick 3 changes from Release-0-M116 chore: cherry-pick 5 changes from Release-0-M116 Aug 19, 2023
@ppontes ppontes marked this pull request as ready for review August 19, 2023 00:27
@zcbenz zcbenz merged commit f22a5b8 into 24-x-y Aug 21, 2023
15 checks passed
@zcbenz zcbenz deleted the cherry-pick/security/24-x-y/release-0-m116 branch August 21, 2023 00:39
@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023

Release Notes Persisted

  • Security: backported fix for CVE-2023-4355.
  • Security: backported fix for CVE-2023-4354.
  • Security: backported fix for CVE-2023-4353.
  • Security: backported fix for CVE-2023-4352.
  • Security: backported fix for CVE-2023-4351.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants