feat: allow generating accessible pdf with printToPDF
#39563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
deepak1556
approved these changes
Aug 17, 2023
codebytere
force-pushed
the
feat-generate-tagged-pdf
branch
3 times, most recently
from
8cde354
to
bfb636e
Compare
codebytere
commented
Aug 17, 2023
| @@ -25,7 +25,7 @@ | |||
| "mocha": "^10.0.0", | |||
| "mocha-junit-reporter": "^1.18.0", | |||
| "mocha-multi-reporters": "^1.1.7", | |||
| "pdfjs-dist": "^2.2.228", | |||
There was a problem hiding this comment.
This is needed to pull in getMarkInfo()
codebytere
force-pushed
the
feat-generate-tagged-pdf
branch
from
bfb636e
to
93d50fa
Compare
dsanders11
reviewed
Aug 17, 2023
codebytere
force-pushed
the
feat-generate-tagged-pdf
branch
from
93d50fa
to
f4358c4
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
jkleinsc
approved these changes
Aug 24, 2023
|
Release Notes Persisted
|
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: allow generating accessible pdf with printToPDF * docs: mark generateTaggedPDF experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1469961
Refs #39375.
Page.printToPDFnow allows for experimentally generating tagged (accessible) PDFs. We needed to add the property to our implementation in the latest Chromium roll in order to fix compilation errors, but we should surface this new property to developers with a note about its experimental status.Checklist
npm testpassesRelease Notes
Notes: Added a
generateTaggedPDFoption towebContents.printToPDFto allow generating tagged (accessible) PDFs.