-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: promise resolved to early when browser initiated in-page navigation v2 #39597
fix: promise resolved to early when browser initiated in-page navigation v2 #39597
Conversation
@codebytere I reintroduced fix for loadURL promise, but somehow linux and mac build are failing. Can you paste me details about these failed tests because I don't have access to CircleCI. Thanks |
@TomaszMa You should be able to login to CircleCI with your GitHub account. |
The failing tests seem to be unrelated to this PR, I have restarted the CI tests. |
Release Notes Persisted
|
I have automatically backported this PR to "25-x-y", please check out #39678 |
I have automatically backported this PR to "26-x-y", please check out #39679 |
I have automatically backported this PR to "27-x-y", please check out #39680 |
Reintroduce fix for loadURL promise resolved to early when browser initiated in-page navigation.
Fix was revered because test which was added in original PR was failing on linux. Now test is fixed.
Original PR: #39260
Revert PR: #39481
Description of Change
Checklist
npm test
passesRelease Notes
Notes: Fix problem with promise resolved to early when browser initiated in-page navigation.