feat: add more extensions manifest key options #39599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/minor
zcbenz
approved these changes
Aug 22, 2023
codebytere
added
semver/minor
codebytere
force-pushed
the
manifest-keys
branch
from
7c00157
to
96c2af8
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
jkleinsc
approved these changes
Aug 28, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/25-x-y
This was referenced Aug 28, 2023
|
I have automatically backported this PR to "27-x-y", please check out #39672 |
trop
bot
removed
the
target/27-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39673 |
trop
bot
added
in-flight/26-x-y
merged/27-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
feat: add more manifest key options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for several more commonly used
manifest.jsonextension key properties:author- an optional manifest key that takes an object with an "email" keyhost_permissions- host permissions are specified as match patterns, and each pattern identifies a group of URLs for which the extension is requesting extra privilegesshort_name- a short name for the extension, where if given, will be used in contexts where thenamefield is too long.Checklist
npm testpassesRelease Notes
Notes: Added support for several more extensions manifest keys including
host_permissions,author, andshort_name