fix: webview exiting fullscreen presentation mode #39616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
electron-cation
bot
added
new-pr 🌱
zcbenz
approved these changes
Aug 25, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
removed
the
target/25-x-y
|
I was unable to backport this PR to "26-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #39660 |
trop
bot
added
in-flight/27-x-y
merged/27-x-y
3 tasks
trop
bot
added
in-flight/26-x-y
merged/26-x-y
|
@codebytere has manually backported this PR to "25-x-y", please check out #40411 |
trop
bot
added
in-flight/25-x-y
merged/25-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35304
Fixes an issue where escape keypresses were skipped in intermediate webContents. This tweaks the
PreHandleKeyboardEventkeypress handling for fullscreen escaping such that we send the keypress to the primary webContents and then traverse through containing webContents if they need to react when leaving fullscreen. Here, PDFs did not properly exit Present mode when they were contained within WebViews because the existing logic skipped directly to the outermost webView.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where pressing the escape key did not properly trigger PDF presentation mode exit.