fix: use generic capturer to list both screens and windows when possible #39711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trop
bot
added
24-x-y
backport
3 tasks
jkleinsc
previously requested changes
Sep 6, 2023
aiddya
force-pushed
the
24-x-y-pipewire-double-popup
branch
from
a153137
to
b9e7ba5
Compare
|
I've updated the patches. I didn't realize that they were out of date as |
|
@aiddya |
Screensharing with PipeWire via XDG Desktop Portal requires explicit user permission via permission dialogs. Chromium has separate tabs for screens and windows and thus its portal implementation requests permissions separately for each. However, the screencast portal has no such limitation and supports both screens and windows in a single request. WebRTC now supports this type of capture in a new method called called `CreateGenericCapturer`. The `desktopCapturer` implementation has been modified to use it. Additionally, Chromium has been patched to use same generic capturer to ensure that the source IDs remain valid for `getUserMedia`.
aiddya
force-pushed
the
24-x-y-pipewire-double-popup
branch
from
4c16a2a
to
12f72db
Compare
|
Rebased |
codebytere
dismissed
jkleinsc’s stale review
Failing patch application has been addressed
codebytere
approved these changes
Sep 25, 2023
jkleinsc
approved these changes
Sep 25, 2023
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #39111
Backporting this because the double screen sharing dialogs introduced by #38833 sometimes cause focus bugs, where one dialog is perfectly superimposed on the other, but the bottom one has focus. The top dialog is not clickable, which leaves the impression that the application has frozen.
cc @VerteDinde
Checklist
npm testpassesRelease Notes
Notes: Fixed a redundant permission popup while fetching screens and windows using
desktopCapturer.getSources()on Wayland.