Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make titlebar opaque while fullscreen #39759

Merged
merged 1 commit into from Sep 7, 2023
Merged

fix: make titlebar opaque while fullscreen #39759

merged 1 commit into from Sep 7, 2023

Conversation

MarshallOfSound
Copy link
Member

Screenshots included for reference

Windowed Fullscreen
Before image image
After image image

Note in fullscreen the titlebar only "peeks" over the content if you mouseover the top of the screen, it doesn't take up any frame dimensions

Notes: Fixed issue where titlebar would be transparent for transparent windows that are fullscreen

@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 6, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2023
samuelmaddock
samuelmaddock approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@MarshallOfSound MarshallOfSound removed the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 7, 2023
@MarshallOfSound MarshallOfSound merged commit 0b44f43 into main Sep 7, 2023
23 checks passed
@MarshallOfSound MarshallOfSound deleted the fix-titlebar-transparency branch September 7, 2023 22:55
@release-clerk
Copy link

release-clerk bot commented Sep 7, 2023

Release Notes Persisted

Fixed issue where titlebar would be transparent for transparent windows that are fullscreen

This was referenced Sep 7, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 7, 2023

I have automatically backported this PR to "25-x-y", please check out #39779

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Sep 7, 2023
@trop
Copy link
Contributor

trop bot commented Sep 7, 2023

I have automatically backported this PR to "26-x-y", please check out #39780

@trop
Copy link
Contributor

trop bot commented Sep 7, 2023

I have automatically backported this PR to "27-x-y", please check out #39781

@trop trop bot added in-flight/26-x-y in-flight/27-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 7, 2023
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/26-x-y in-flight/25-x-y in-flight/27-x-y labels Sep 9, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@MarshallOfSound
fix: make titlebar opaque while fullscreen (electron#39759)
093899e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MarshallOfSound @zcbenz @samuelmaddock @codebytere @VerteDinde