fix: keyCodes being incorrectly converted in webContents.sendInputEvent()
#39776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-input-event-parsing
branch
from
ea7d76a
to
1d6c8fc
Compare
VerteDinde
approved these changes
Sep 8, 2023
codebytere
force-pushed
the
fix-input-event-parsing
branch
from
1d6c8fc
to
2fd946e
Compare
codebytere
force-pushed
the
fix-input-event-parsing
branch
from
2fd946e
to
8146af1
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "25-x-y", please check out #39820 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39821 |
|
I have automatically backported this PR to "27-x-y", please check out #39822 |
trop
bot
added
in-flight/26-x-y
in-flight/27-x-y
merged/26-x-y
trop
bot
added
merged/27-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…Event()` (electron#39776) fix: sendInputEvent keyCodes being incorrectly converted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39610.
Fixed an issue where accelerators representing DOM keys were not correctly converted in
webContents.sendInputEvent(). This was happening because our internal conversion logic was correctly parsing strings their respectiveui::KeyboardCodevalues, but then failing to check whether the DOM code represented a standalone valid character. This led to an issue where a call to, for example,w.webContents.sendInputEvent({ keyCode: 'Plus', type: 'char' })would get truncated and then sent to the input as the char string and not the dom key character if one existed.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where accelerators representing DOM keys were not correctly converted in
webContents.sendInputEvent().