Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @electron/typescript-definitions to fix titlebaroverlay #39799

Merged
merged 1 commit into from Sep 11, 2023

Conversation

MarshallOfSound
Copy link
Member

Fixes #39790

Notes: Fixed missing type for Electron.TitleBarOverlay

@MarshallOfSound MarshallOfSound added target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. semver/patch backwards-compatible bug fixes and removed semver/none labels Sep 11, 2023
@MarshallOfSound MarshallOfSound merged commit ac040bf into main Sep 11, 2023
21 checks passed
@MarshallOfSound MarshallOfSound deleted the update-ts-defs branch September 11, 2023 18:36
@release-clerk
Copy link

release-clerk bot commented Sep 11, 2023

Release Notes Persisted

Fixed missing type for Electron.TitleBarOverlay

@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "26-x-y", please check out #39805

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Sep 11, 2023
@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "27-x-y", please check out #39806

@trop trop bot added in-flight/27-x-y merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/26-x-y in-flight/27-x-y labels Sep 11, 2023
@ckerr ckerr changed the title build: update @electron/typescript-definitions to fix titlebaroverlay fix: update @electron/typescript-definitions to fix titlebaroverlay Nov 28, 2023
@ckerr
Copy link
Member

ckerr commented Nov 28, 2023

In case anyone wonders, the reason for changing the title prefix from chore: to fix:, even though cherry-picking was a chore, is to make the release notes script happy.

Marking the title as a fix: ensures the Notes "Fixed launch failure..." shows up under the Fixes section instead of the Other Changes section 😸

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
…electron#39799)

build: update @electron/typescript-definitions to fix titlebarstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TitleBarOverlay is empty interface
3 participants