-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app.runningUnderARM64Translation()
always returning true on Windows ARM64
#39920
Conversation
Can we just call into the upstream implementation instead ? |
f6dc698
to
80c939b
Compare
@deepak1556 done |
app.runningUnderARM64Translation()
always returning true on ARM64app.runningUnderARM64Translation()
always returning true on Windows ARM64
Release Notes Persisted
|
I have automatically backported this PR to "25-x-y", please check out #39930 |
I have automatically backported this PR to "27-x-y", please check out #39931 |
I have automatically backported this PR to "26-x-y", please check out #39932 |
…ndows ARM64 (electron#39920) fix: app.runningUnderARM64Translation() always returning true on ARM64
Description of Change
This is the Chromium implementation added by https://chromium-review.googlesource.com/c/chromium/src/+/4415695
https://source.chromium.org/chromium/chromium/src/+/main:base/win/windows_version.cc;l=127-155
However in Electron we are missing the part, which always returns
false
when compiled for ARM64.So let's just call
base::win::OSInfo::IsRunningEmulatedOnArm64();
This has always been broken since the API was added in #29168
Checklist
npm test
passesRelease Notes
Notes: Fixed
app.runningUnderARM64Translation()
always returning true on Windows ARM64.