Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add middle click event to tray #39926

Merged
merged 2 commits into from Sep 27, 2023

Conversation

TomaszMa
Copy link
Contributor

Description of Change

Add middle click mouse event to tray icon. This event is available only on Windows.

Checklist

Release Notes

Notes: Add middle click mouse event to tray icon.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 20, 2023
@TomaszMa
Copy link
Contributor Author

@codebytere can you look on this feature. What do you think ?
Linux and Mac pipelines currently failing, but I don't think that this change is causing it. On Linux CI there is problem with goma. On Mac CI there is something wrong with src cache.

@zcbenz zcbenz added semver/minor backwards-compatible functionality no-backport labels Sep 25, 2023
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2023
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit 689d1b7 into electron:main Sep 27, 2023
14 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 27, 2023

Release Notes Persisted

Add middle click mouse event to tray icon.

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants