Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick tls shutdown crash fix from upstream #39928

Merged
merged 1 commit into from Sep 21, 2023
Merged

fix: cherry-pick tls shutdown crash fix from upstream #39928

merged 1 commit into from Sep 21, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

Backports nodejs/node@048e0be, nodejs/node@ccf46ba and nodejs/node@f863117...47add7e

Needed for microsoft/vscode#188676

Release Notes

Notes: fix crash on shutdown in tls sockets with Node.js HTTP/2 connections

@deepak1556 deepak1556 requested a review from a team as a code owner September 20, 2023 13:22
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 20, 2023
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 20, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 20, 2023
@jkleinsc jkleinsc merged commit 5f712fa into main Sep 21, 2023
24 checks passed
@jkleinsc jkleinsc deleted the robo/backport_tls_crash_fix branch September 21, 2023 13:47
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2023 •
edited by ckerr

Release Notes Persisted

fix crash on shutdown in TLS sockets with Node.js HTTP/2 connections

This was referenced Sep 21, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 21, 2023

I have automatically backported this PR to "25-x-y", please check out #39945

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Sep 21, 2023
@trop trop bot mentioned this pull request Sep 21, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 21, 2023

I have automatically backported this PR to "26-x-y", please check out #39946

@trop
Copy link
Contributor

trop bot commented Sep 21, 2023

I have automatically backported this PR to "27-x-y", please check out #39947

@trop trop bot added in-flight/26-x-y in-flight/27-x-y merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/26-x-y in-flight/27-x-y labels Sep 21, 2023
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y labels Sep 21, 2023
@jkleinsc jkleinsc mentioned this pull request Sep 21, 2023
Merged
2 tasks
codebytere pushed a commit that referenced this pull request Sep 22, 2023
@deepak1556 @codebytere
chore: cherry-pick tls shutdown crash fix from upstream (#39928)
8651508
@ckerr
Copy link
Member

ckerr commented Nov 28, 2023

In case anyone wonders, the reason for changing the title prefix from chore: to fix:, even though cherry-picking was a chore, is to make the release notes script happy.

Marking the title as a fix: ensures the Notes "Fixed launch failure..." shows up under the Fixes section instead of the Other Changes section 😸

@ckerr ckerr changed the title chore: cherry-pick tls shutdown crash fix from upstream fix: cherry-pick tls shutdown crash fix from upstream Nov 28, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@deepak1556
chore: cherry-pick tls shutdown crash fix from upstream (electron#39928)
cc40c43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepak1556 @ckerr @jkleinsc