Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated app.runningUnderRosettaTranslation() #39956

Merged
merged 2 commits into from Oct 2, 2023
Merged

chore: remove deprecated app.runningUnderRosettaTranslation() #39956

merged 2 commits into from Oct 2, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 22, 2023

Description of Change

Follow-up to #39897

Checklist

Release Notes

Notes: Removed deprecated app.runningUnderRosettaTranslation()

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2023
@miniak miniak self-assigned this Sep 22, 2023
@miniak miniak added semver/major incompatible API changes no-backport labels Sep 22, 2023
@miniak miniak marked this pull request as ready for review September 26, 2023 21:05
@miniak miniak requested review from a team as code owners September 26, 2023 21:05
@electron-cation
Copy link

electron-cation bot commented Sep 27, 2023 •
edited by dsanders11

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 🏷️ Pull request is labeled as semver/major incompatible API changes
  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

codebytere
codebytere approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops accidentally re-requested myself

RaisinTen
RaisinTen approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jkleinsc
jkleinsc reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak
Copy link
Contributor Author

miniak commented Oct 2, 2023

@codebytere can you please approve / merge?

codebytere
codebytere approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit d301616 into main Oct 2, 2023
15 of 16 checks passed
@codebytere codebytere deleted the miniak/remove-rosetta-api branch October 2, 2023 08:55
@release-clerk
Copy link

release-clerk bot commented Oct 2, 2023

Release Notes Persisted

Removed deprecated app.runningUnderRosettaTranslation()

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: remove deprecated app.runningUnderRosettaTranslation() (elec…
d6196ce 
…tron#39956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc left review comments

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

@miniak miniak

Labels
api-review/requested 🗳 deprecation-review/complete ✅ new-pr 🌱 PR opened in the last 24 hours no-backport semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @jkleinsc @zcbenz @codebytere @RaisinTen @dsanders11