fix: rounded corners on vibrant macOS modals #39979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
VerteDinde
approved these changes
Sep 26, 2023
zcbenz
approved these changes
Sep 26, 2023
|
Release Notes Persisted
|
This was referenced Sep 27, 2023
|
I have automatically backported this PR to "27-x-y", please check out #39996 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "25-x-y", please check out #39997 |
|
I have automatically backported this PR to "26-x-y", please check out #39998 |
trop
bot
added
in-flight/25-x-y
in-flight/26-x-y
merged/27-x-y
trop
bot
added
merged/26-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39960.
Fixes an issue where vibrant windows incorrectly have square corners when they're modals. This was initially changed in #24250 in response to the current design of macOS whereby modals were flush to the top of their parent window, which is no longer the case. There also isn't really a concept of framelessness on parented modals, so that condition only applies to non-modal windows.
Before
After
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where vibrant windows incorrectly have square corners when they're modals on macOS.