Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all children showing when showing child window #40062

Merged
merged 1 commit into from Oct 5, 2023
Merged

fix: all children showing when showing child window #40062

merged 1 commit into from Oct 5, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Closes #39704.

Fixes an issue where calling show() on a child BrowserWindow would incorrectly show all other children attached to the same parent. This was happening because logic to handle de- and re-attachment of children to a parent window did not properly take into account whether the window was visible prior. I will likely follow this up with a bit more of a cleanup around parent-child attachment logic but this fixes the immediate issue similarly to Chromium

Checklist

Release Notes

Notes: Fixes an issue where calling show() on a child BrowserWindow would show all other children attached to the same parent on macOS.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 2, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2023
jkleinsc
jkleinsc requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs some test cleanup.

spec/api-browser-window-spec.ts Outdated Show resolved Hide resolved
spec/api-browser-window-spec.ts Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 3, 2023
@codebytere codebytere requested review from VerteDinde and removed request for deepak1556 October 4, 2023 08:40
@jkleinsc jkleinsc merged commit 3392d9a into main Oct 5, 2023
18 checks passed
@jkleinsc jkleinsc deleted the fix-unwanted-children branch October 5, 2023 13:20
@release-clerk
Copy link

release-clerk bot commented Oct 5, 2023

Release Notes Persisted

Fixes an issue where calling show() on a child BrowserWindow would show all other children attached to the same parent on macOS.

This was referenced Oct 5, 2023
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 5, 2023

I have automatically backported this PR to "24-x-y", please check out #40104

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Oct 5, 2023
@trop
Copy link
Contributor

trop bot commented Oct 5, 2023

I have automatically backported this PR to "27-x-y", please check out #40105

@trop trop bot added the in-flight/27-x-y label Oct 5, 2023
@trop
Copy link
Contributor

trop bot commented Oct 5, 2023

I have automatically backported this PR to "25-x-y", please check out #40106

@trop
Copy link
Contributor

trop bot commented Oct 5, 2023

I have automatically backported this PR to "26-x-y", please check out #40107

@trop trop bot added in-flight/25-x-y in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/27-x-y in-flight/26-x-y in-flight/24-x-y labels Oct 5, 2023
@togume togume mentioned this pull request Oct 11, 2023
Closed
3 tasks
@tzahola tzahola mentioned this pull request Nov 16, 2023
Merged
3 tasks
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: all children showing when showing child window (electron#40062)
ee0f5a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: calling show() on child browser window will show all other children starting electron@24.7.0
2 participants
@codebytere @jkleinsc