fix: toggling DevTools while minimized on Windows #40091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
dsanders11
approved these changes
Oct 4, 2023
zcbenz
approved these changes
Oct 6, 2023
jkleinsc
approved these changes
Oct 6, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "27-x-y", please check out #40116 |
trop
bot
removed
the
target/27-x-y
|
I have automatically backported this PR to "25-x-y", please check out #40117 |
|
I have automatically backported this PR to "26-x-y", please check out #40118 |
trop
bot
added
in-flight/25-x-y
in-flight/26-x-y
merged/25-x-y
trop
bot
added
merged/26-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
fix: toggling devtools while minimized on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39991.
Fixes an issue where if a user opened DevTools in detached mode, minimized the DevTools window, and then toggled DevTools off and on again, the window would no longer be visible to the user. This was happening because our existing logic saved the last known DevTools window bounds prior to closure, and then attempted to restore to those bounds if the DevTools window was re-opened. However, if the window was minimized prior to being toggled off, then the saved bounds would be wildly inaccurate as a result of our calling
GetWindowBoundsInScreen():InspectableWebContents::SaveDevToolsBounds(): -16000,-16000 157x25This fixes that by using the normal bounds if the window is not currently on screen.
Tested with https://gist.github.com/c985de2d95ffedb47bc966edaf3bfe8c
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where closing and opening a minimized DevTools window would not work as expected.