Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix vibrancy applying without transparency on MacOS #40109

Merged
merged 2 commits into from Oct 6, 2023
Merged

fix: fix vibrancy applying without transparency on MacOS #40109

merged 2 commits into from Oct 6, 2023

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Oct 5, 2023 •
edited

Description of Change

A follow-up to #39708 - this PR fixes applying transparency as a background color when vibrancy is also set.

Closes #40039

Checklist

Release Notes

Notes: Fixed an issue with applying vibrancy on non-transparent windows on MacOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 5, 2023
@VerteDinde VerteDinde added target/27-x-y PR should also be added to the "27-x-y" branch. semver/patch backwards-compatible bug fixes labels Oct 5, 2023
@VerteDinde VerteDinde marked this pull request as ready for review October 5, 2023 22:14
@VerteDinde VerteDinde changed the title fix: fix vibrancy applying without transparency fix: fix vibrancy applying without transparency on MacOS Oct 5, 2023
@VerteDinde @samuelmaddock
fix: initiate backgroundMaterial and vibrancy earlier in native window
a241d95 
Co-authored-by: samuelmaddock <samuelmaddock@electronjs.org>
@VerteDinde VerteDinde merged commit cff50ac into main Oct 6, 2023
16 checks passed
@VerteDinde VerteDinde deleted the fix-transparency-mac branch October 6, 2023 18:57
@release-clerk
Copy link

release-clerk bot commented Oct 6, 2023 •
edited by ckerr

Release Notes Persisted

Fixed an issue with applying vibrancy on non-transparent windows on macOS.

@trop trop bot mentioned this pull request Oct 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 6, 2023

I have automatically backported this PR to "27-x-y", please check out #40130

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Oct 6, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@VerteDinde
fix: fix vibrancy applying without transparency on MacOS (electron#40109
af65fcd 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@clavin clavin clavin approved these changes

Assignees
No one assigned
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserWindow vibrancy doesn't apply without transparency
4 participants
@VerteDinde @zcbenz @samuelmaddock @clavin