fix: crash when calling non-reentrant function in loadURL
#40143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-loadurl-crash
branch
from
6b78b97
to
e5c74ba
Compare
codebytere
force-pushed
the
fix-loadurl-crash
branch
from
e5c74ba
to
0bd50f0
Compare
dsanders11
approved these changes
Oct 9, 2023
|
Release Notes Persisted
|
This was referenced Oct 10, 2023
|
I have automatically backported this PR to "24-x-y", please check out #40160 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
|
I have automatically backported this PR to "25-x-y", please check out #40161 |
|
I have automatically backported this PR to "27-x-y", please check out #40162 |
|
I have automatically backported this PR to "26-x-y", please check out #40163 |
trop
bot
added
in-flight/27-x-y
and removed
target/25-x-y
trop
bot
added
in-flight/26-x-y
merged/24-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
14 tasks
sfoster1
added a commit
to Opentrons/opentrons
that referenced
this pull request
Jan 31, 2024
…omponents,labware-designer): update Electron version to v27.0.0 (#14314) Update Electron version 27.0.0 https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline This is the latest version of electron that does not include electron/electron#40143 which breaks the ability of the ODD to load content. This PR also includes Nodejs update because of Electron v27's requirement. The more recent nodejs requires some new options; specifically, webpack dev servers must serve on ipv6 wildcards, and internally in the shell we need to prefer v4 dns. We also need to use old openssl. --------- Co-authored-by: Brent Hagen <brent.hagen@opentrons.com> Co-authored-by: Seth Foster <seth@opentrons.com>
ncdiehl11
pushed a commit
to Opentrons/opentrons
that referenced
this pull request
Feb 1, 2024
…omponents,labware-designer): update Electron version to v27.0.0 (#14314) Update Electron version 27.0.0 https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline This is the latest version of electron that does not include electron/electron#40143 which breaks the ability of the ODD to load content. This PR also includes Nodejs update because of Electron v27's requirement. The more recent nodejs requires some new options; specifically, webpack dev servers must serve on ipv6 wildcards, and internally in the shell we need to prefer v4 dns. We also need to use old openssl. --------- Co-authored-by: Brent Hagen <brent.hagen@opentrons.com> Co-authored-by: Seth Foster <seth@opentrons.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #19847.
Refs http://crbug.com/347742.
Handles an issue where calling
loadURLduring somewebContentsurl loading events could crash.There are a few possible ways to handle this, as outlined in #19847 (comment) - I decided to take the path of simply failing to load if we're currently in a non-reentrant loadURL function.
This crash was happening because it's not safe to start a new navigation or otherwise discard the current one while the call that started it is still on the stack. When this happens, we can see use-after-frees, which Chrome preemptively handles with CHECKs.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where calling
loadURLduring somewebContentsurl loading events could crash.