Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support the throwIfNoEntry option to statSync and lstatSync in asar files #40224

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 16, 2023

Backport of #40221

See that PR for details.

Notes:

  • Fixed loading nested ESM dependencies in node_modules
  • Correctly support the throwIfNoEntry option in fs.statSync/fs.lstatSync in asar files

…sar files

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@trop trop bot requested a review from MarshallOfSound October 16, 2023 16:35
@trop trop bot added 28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 16, 2023
@codebytere
Copy link
Member

Unrelated Node.js failure - see #40241

@codebytere codebytere merged commit 9ddd08b into 28-x-y Oct 18, 2023
16 of 17 checks passed
@codebytere codebytere deleted the trop/28-x-y-bp-fix-support-the-throwifnoentry-option-to-statsync-and-lstatsync-in-asar-files-1697474137565 branch October 18, 2023 09:33
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

Release Notes Persisted

Fixed loading nested ESM dependencies in node_modules. Support the throwIfNoEntry option in fs.statSync/fs.lstatSync in asar files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants