Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure use remote checksums via rc #40253

Merged
merged 2 commits into from Oct 31, 2023
Merged

feat: configure use remote checksums via rc #40253

merged 2 commits into from Oct 31, 2023

Conversation

Ninglo
Copy link
Contributor

@Ninglo Ninglo commented Oct 18, 2023 •
edited by jkleinsc

Description of Change

Resolves #31431

Checklist

Release Notes

Notes: Added support for configuring use_remote_checksums via .npmrc.

@Ninglo Ninglo requested a review from a team as a code owner October 18, 2023 09:42
@welcome
Copy link

welcome bot commented Oct 18, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2023
@Ninglo Ninglo changed the title Chore/configure use remote checksums via rc chore: configure use remote checksums via rc Oct 18, 2023
@Ninglo Ninglo force-pushed the chore/configure_use_remote_checksums_via_rc branch from 4df294f to 4504b7a Compare October 18, 2023 11:05
@Ninglo Ninglo changed the title chore: configure use remote checksums via rc feat: configure use remote checksums via rc Oct 19, 2023
@Ninglo
Copy link
Contributor Author

Ninglo commented Oct 21, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

I have already changed the pull request title. However, there hasn't been a reply to my pull request in 3 days. Are there any questions regarding my pull request? Please let me know, and I will address them. Thanks for your hard work.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2023
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label Oct 31, 2023
erickzhao
erickzhao approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

MarshallOfSound
MarshallOfSound approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit f526206 into electron:main Oct 31, 2023
18 of 21 checks passed
@welcome Welcome
Copy link

welcome bot commented Oct 31, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk Release Clerk
Copy link

release-clerk bot commented Oct 31, 2023

Release Notes Persisted

Added support for configuring use_remote_checksums via .npmrc.

@Ninglo Ninglo deleted the chore/configure_use_remote_checksums_via_rc branch November 1, 2023 00:40
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@Ninglo
feat: configure use remote checksums via rc (electron#40253)
9fb34e5 
* feat: support for configuring use_remote_checksums via .npmrc

* docs: support for configuring use_remote_checksums via .npmrc

---------

Co-authored-by: jiujianian <jiujianian@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Set ELECTRON_USE_REMOTE_CHECKSUMS from .npmrc
5 participants
@Ninglo @jkleinsc @ckerr @MarshallOfSound @erickzhao