Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated gpu-process-crashed event #40255

Merged
merged 2 commits into from Oct 26, 2023
Merged

chore: remove deprecated gpu-process-crashed event #40255

merged 2 commits into from Oct 26, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 18, 2023

Description of Change

Follow-up to #40169

Checklist

Release Notes

Notes: The deprecated gpu-process-crashed event on app has been removed.

@miniak miniak added semver/major incompatible API changes no-backport labels Oct 18, 2023
@miniak miniak self-assigned this Oct 18, 2023
@miniak miniak requested a review from a team as a code owner October 18, 2023 10:15
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Oct 18, 2023
@miniak miniak force-pushed the miniak/remove-gpu-process-crashed branch from 8e495f9 to 0cee678 Compare October 18, 2023 10:17
@electron-cation
Copy link

electron-cation bot commented Oct 18, 2023 •
edited by miniak

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 🏷️ Pull request is labeled as semver/major incompatible API changes
  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

jkleinsc
jkleinsc approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

zcbenz
zcbenz approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

and code also lgtm

@ckerr ckerr merged commit 30fbcfc into main Oct 26, 2023
17 checks passed
@ckerr ckerr deleted the miniak/remove-gpu-process-crashed branch October 26, 2023 18:05
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2023

Release Notes Persisted

The deprecated gpu-process-crashed event on app has been removed.

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak @jkleinsc
chore: remove deprecated gpu-process-crashed event (electron#40255)
2209da0 
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
api-review/approved ✅ deprecation-review/complete ✅ no-backport semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @ckerr @jkleinsc @zcbenz