Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keyboard.lock() should use permissions helper #40369

Merged
merged 1 commit into from Nov 6, 2023
Merged

feat: keyboard.lock() should use permissions helper #40369

merged 1 commit into from Nov 6, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Similar APIs are routed through our permissions helper, and it breaks from our permissions expectations to have this API not be controllable through ses.setPermissionRequestHandler(handler).

This change brings it in line with other APIs like the Pointer Lock API.

Checklist

Release Notes

Notes: Added keyboardLock to ses.setPermissionRequestHandler(handler).

@codebytere codebytere added semver/minor backwards-compatible functionality target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 30, 2023
@codebytere codebytere requested review from jkleinsc and a team October 30, 2023 14:31
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Oct 30, 2023
jkleinsc
jkleinsc approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM as well

erickzhao
erickzhao approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit 7999ea3 into main Nov 6, 2023
25 checks passed
@codebytere codebytere deleted the permissions-keyboard-lock branch November 6, 2023 19:54
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 6, 2023

Release Notes Persisted

Added keyboardLock to ses.setPermissionRequestHandler(handler).

@trop trop bot mentioned this pull request Nov 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Nov 6, 2023

I have automatically backported this PR to "26-x-y", please check out #40458

@trop trop bot added the in-flight/26-x-y label Nov 6, 2023
@trop trop bot mentioned this pull request Nov 6, 2023
Merged
@trop trop bot removed the target/26-x-y PR should also be added to the "26-x-y" branch. label Nov 6, 2023
@trop trop bot mentioned this pull request Nov 6, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Nov 6, 2023

I have automatically backported this PR to "27-x-y", please check out #40459

@trop
Copy link
Contributor

trop bot commented Nov 6, 2023

I have automatically backported this PR to "28-x-y", please check out #40460

@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/28-x-y in-flight/27-x-y in-flight/26-x-y labels Nov 6, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
feat: keyboard.lock() should use permissions helper (electron#40369)
f236990 
feat: `keyboard.lock()` should use permissions helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅ merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codebytere @ckerr @jkleinsc @dsanders11 @erickzhao