Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add/update missing Display properties #40497

Merged
merged 1 commit into from Nov 17, 2023
Merged

feat: add/update missing Display properties #40497

merged 1 commit into from Nov 17, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 9, 2023 •
edited

Description of Change

This PR adds missing display properties upstream as well as corresponding tests. Also alphabetizes the properties in docs.

Checklist

Release Notes

Notes: This PR adds several properties to the display object including detected, maximumCursorSize, and nativeOrigin.

@codebytere codebytere added semver/minor backwards-compatible functionality target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 9, 2023
@codebytere codebytere requested review from jkleinsc, zcbenz and a team November 9, 2023 19:23
@electron-cation electron-cation bot added api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours labels Nov 9, 2023
erickzhao
erickzhao approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

jkleinsc
jkleinsc approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit 471449d into main Nov 17, 2023
24 checks passed
@codebytere codebytere deleted the display-detected branch November 17, 2023 09:43
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 17, 2023

Release Notes Persisted

This PR adds several properties to the display object including detected, maximumCursorSize, and nativeOrigin.

@trop trop bot mentioned this pull request Nov 17, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Nov 17, 2023

I have automatically backported this PR to "28-x-y", please check out #40554

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 17, 2023
@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/28-x-y labels Nov 27, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
feat: add/update missing Display properties (electron#40497)
f53315a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@erickzhao erickzhao erickzhao approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
api-review/approved ✅ merged/28-x-y PR was merged to the "28-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codebytere @ckerr @jkleinsc @VerteDinde @erickzhao